Fix sdpfa_fwd to not assume the presence of DIDs. #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
!build |
wujingyue
commented
Oct 7, 2024
samnordmann
approved these changes
Oct 7, 2024
| self.sched.parallelize(t, 0, nvfuser.ParallelType.mesh_x) | ||
|
|
||
| torch.cuda.set_device(mpi_test.local_rank) | ||
| torch.manual_seed(0) |
There was a problem hiding this comment.
shouldn't we make the seed manual for all tests, and put this line in the test's constructor ?
There was a problem hiding this comment.
Yes and cc @Priya2698 who briefly mentioned how this should be done which I forgot :) We do have
Line 387 in 61a77e0
There was a problem hiding this comment.
We are using this with pytest:
Fuser/tests/python/test_python_frontend.py
Lines 41 to 42 in e01e23e
What do you mean by doing it differently for pytest?
|
!build |
wujingyue
added a commit
that referenced
this pull request
Oct 10, 2024
wujingyue
added a commit
that referenced
this pull request
Oct 17, 2024
wujingyue
added a commit
that referenced
this pull request
Oct 17, 2024
wujingyue
added a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3073,
sdpfa_fwdshouldn't assume DIDs are available at definition time. Instead, treat extra preceding dimensions as batch at definition time and check they are device parallel at evaluation time.This is required to land #3115.