New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CircularBufferLoopCloner #2823

Merged

rdspring1 merged 2 commits into main from cb_pass_refactor

Aug 27, 2024

Collaborator

rdspring1 commented Aug 21, 2024 •

edited

Loading

This PR refactors CircularBufferLoopCloner to avoid clang-tidy issues in #2773.

Track cloned for loop instead of its Scope
Add virtual methods processExpr and processForLoop for TmaCircularBufferLoopCloner to override.

Details:

  Error (CLANGTIDY) [bugprone-parent-virtual-call,-warnings-as-errors]
    qualified name 'kir::IrVisitor::dispatch' refers to a member overridden in
    subclass; did you mean 'nvfuser::CircularBufferLoopCloner'?


          refactor

3ee6454

zasdfgbnm approved these changes

View reviewed changes


          Merge branch 'main' into cb_pass_refactor

31fdbc4

Collaborator Author

rdspring1 commented Aug 27, 2024

!build

rdspring1 merged commit 742f24c into main

36 checks passed

rdspring1 deleted the cb_pass_refactor branch

August 27, 2024 15:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet