Skip to content

Commit

Permalink
Comment why tv1c is not inlined to position 1
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobhinkle committed Dec 10, 2024
1 parent a902803 commit ff358f7
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/cpp/test_matmul.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3941,9 +3941,12 @@ TEST_F(HopperMatmulTest, HSH_NT_128BSwizzle_NoBroadcasts) {
// of 3
ir_cloner.clone(tv2)->reorder({{2, 1}, {1, 2}});
inlineMost();
tmp_fusion.printMath();
ir_cloner.clone(tv2)->reorder({{2, 1}, {1, 2}});
EXPECT_EQ(ir_cloner.clone(tv0c)->getComputeAtPosition(), 1);
// TODO: why is tv1c not inlined past the broadcast Mo dimension?
// The outermost loop dim of tv1c is a broadcast Mo axis, so
// tv1c->inlineAt(1) does not inline past that axis and we wind up with
// compute-at position 0.
EXPECT_EQ(ir_cloner.clone(tv1c)->getComputeAtPosition(), 0);
}

Expand Down

0 comments on commit ff358f7

Please sign in to comment.