Skip to content

Commit

Permalink
Disable modernize-loop-convert (#1356)
Browse files Browse the repository at this point in the history
This is asking to convert loops like
```C++
for (auto it = exprs.rbegin(); it != exprs.rend(); ++it)
```
into
```C++
for (auto expr : std::ranges::reverse_view(exprs))
```
However, seems that clang <16 can not compile the latter code

So disable this check for now to unblock. If we want to upgrade clang
versions, we can re-enable it.
  • Loading branch information
zasdfgbnm authored Nov 21, 2023
1 parent f4c4d86 commit 7a46d10
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ modernize-*,
-modernize-use-using,
-modernize-use-trailing-return-type,
-modernize-use-nodiscard,
-modernize-loop-convert,
performance-*,
-performance-noexcept-move-constructor,
-performance-unnecessary-value-param,
Expand Down

0 comments on commit 7a46d10

Please sign in to comment.