Skip to content

Commit

Permalink
Pointwise shouldn't check transpose scheduler (#3256)
Browse files Browse the repository at this point in the history
Removed unnecessary check. 

Codegen diff kept failing with some python tests, which was due to
#3283. Otherwise, no change is detected.

---------

Co-authored-by: Jacob Hinkle <[email protected]>
  • Loading branch information
naoyam and jacobhinkle authored Oct 27, 2024
1 parent 374fa38 commit 628a47e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 21 deletions.
20 changes: 0 additions & 20 deletions csrc/scheduler/pointwise.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <scheduler/registry_utils.h>
#include <scheduler/runtime_info.h>
#include <scheduler/tools/inlining.h>
#include <scheduler/transpose.h>
#include <scheduler/utils.h>
#include <scheduler/vectorize_helper.h>

Expand Down Expand Up @@ -480,25 +479,6 @@ bool PointWiseScheduler::canScheduleCompileTime(Fusion* fusion) {
return true;
}

bool PointWiseScheduler::canScheduleRunTime(
Fusion* fusion,
SchedulerRuntimeInfo& runtime_info,
HeuristicDataCache* data_cache) {
FUSER_PERF_SCOPE("PointWiseScheduler::canScheduleRunTime");
auto can_schedule_transpose_entry =
HeuristicDataCacheEntry<HeuristicCompileTime::CanScheduleTranspose>(
data_cache, [fusion]() {
return std::make_unique<bool>(
TransposeScheduler().canScheduleCompileTime(fusion));
});
if (can_schedule_transpose_entry.get()) {
return !TransposeScheduler().canScheduleRunTime(
fusion, runtime_info, data_cache);
}

return true;
}

// TODO: Inline intermediate operations (avoid inlining unrolled/vectorized
// input/output caches)
void schedulePointwise(Fusion* fusion, const PointwiseParams* pparams) {
Expand Down
4 changes: 3 additions & 1 deletion csrc/scheduler/pointwise.h
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ class PointWiseScheduler : public SchedulerEntry {
bool canScheduleRunTime(
Fusion* fusion,
SchedulerRuntimeInfo& runtime_info,
HeuristicDataCache* data_cache = nullptr) override;
HeuristicDataCache* data_cache = nullptr) override {
return true;
}

std::unique_ptr<HeuristicParams> computeHeuristics(
Fusion* fusion,
Expand Down
1 change: 1 addition & 0 deletions tools/codediff/compare_codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ collect_kernels() {
# Make tests reproducible
export NVFUSER_TEST_RANDOM_SEED=0
export NVFUSER_DISABLE=parallel_compile
export DEBUG_SERDE=true
# run tests and benchmarks with cuda_to_file and dump output to files

mkdir -p "$outdir/$commit"
Expand Down

0 comments on commit 628a47e

Please sign in to comment.