Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDPR info to footer #390

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add GDPR info to footer #390

merged 2 commits into from
Apr 25, 2024

Conversation

mikemckiernan
Copy link
Member

No description provided.

@mikemckiernan mikemckiernan added the documentation Improvements or additions to documentation label Apr 16, 2024
Copy link

Documentation preview

https://nvidia-merlin.github.io/systems/review/pr-390

@mikemckiernan
Copy link
Member Author

I didn't notice the PR to use sphinx-book-theme. I need to change this PR.

@oliverholworthy
Copy link
Member

I didn't notice the PR to use sphinx-book-theme. I need to change this PR.

@mikemckiernan I've merged the sphinx book theme change now. I can rebase this PR and resolve conflicts if you like?

Signed-off-by: Mike McKiernan <[email protected]>
@mikemckiernan
Copy link
Member Author

I didn't notice the PR to use sphinx-book-theme. I need to change this PR.

@mikemckiernan I've merged the sphinx book theme change now. I can rebase this PR and resolve conflicts if you like?

That's fine by me, only that we need changes more like these ones that I made for models:

https://github.com/NVIDIA-Merlin/models/pull/1237/files

@mikemckiernan
Copy link
Member Author

Huge thanks, @oliverholworthy!

@oliverholworthy oliverholworthy merged commit 7d03922 into main Apr 25, 2024
9 checks passed
@oliverholworthy oliverholworthy deleted the gdpr branch April 25, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants