Commented call to checkIfFailed, to fix submissions bug #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operation, to make it possible to write unit tests, and because its only one function that is updating submissions anyway
BUT still failing, with error about `Error: After filtering out keys not in the schema, your modifier is now empty` happening in `adminUpdates`
… and tests pass and fail for the stated reasons, instead of some cuz of timing BS
|
Taking the liberty to close this myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Resolves #51 . Future PR (Issue #60) will need to add the functionality that
checkIfNeedFailedshould have been doing to help with unsuccessful synchronous needs (detailed in the function docs)Tests: Passes 13/14 tests passing
The only one that fails is
In your command line,
npm run testornpm run unittest