Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for loading data from Tiled server at SRX beamline. Several minor fixes.
Issue to fix later: the arrays (Dask arrays) loaded from Tiled have NaNs in place of corrupt values. For example, if a row is missing 3 points in any positions, the last 3 elements of the respective array will be NaNs. PyXRF is currently replacing NaNs with zeros in fluorescent data and with median values for scalers. This is simple, but not the best approach, since this distorts the image. More intelligent handling of missing data should be implemented. Two options exist: replace full corrupt row with zeros (for fluorescence) and with median value (for scalers) or replace full corrupt row with one of the adjacent rows (both for fluorescence and the scalers).
Summary of Changes for Release Notes
Fixed
np.asarray
function in the code compiled by Numba.Added
make_hdf
parameter:catalog
.pyxrf
CLI parameter:--catalog-name
or-c
.Changed
Removed
How Has This Been Tested?
All new functionality was manually tested. PyXRF with changes is used at SRX and TES beamlines .