Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: enable flake8 checks #84

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented May 1, 2024

This way we capture more potential issues.

Although, the number of flake8 errors is significant, many of them are repeating, such as:

...
pyCHX/XPCS_SAXS.py:240:10: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:241:12: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:242:12: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:243:12: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:244:18: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:245:17: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:246:17: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:248:28: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:250:42: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:250:76: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:252:22: F405 'roi' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:253:16: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:254:12: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:256:16: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:258:5: E741 ambiguous variable name 'l'
pyCHX/XPCS_SAXS.py:260:15: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:262:27: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:271:20: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:273:22: F405 'roi' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:274:16: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:275:12: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:276:16: F405 'np' may be undefined, or defined from star imports: pyCHX.chx_generic_functions
pyCHX/XPCS_SAXS.py:277:5: E741 ambiguous variable name 'l'
...

Base automatically changed from updates-20240429-with-style-fixes to main May 3, 2024 13:57
@thomaswmorris
Copy link

How much should be refactoring code to fix the linting issues, and how much should be just excluding files from flake? A lot of the scripts don't seem like they were meant to be submodules but rather just profile scripts. Should I make/add them to a /scripts directory?

@yugangzhang
Copy link
Collaborator

yugangzhang commented May 6, 2024 via email

@thomaswmorris
Copy link

See #88, most of it was automated so testing is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants