Update solvers.py #206
Merged
Update solvers.py #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rixs_1v1c_py: 1) added new option for pol_type: 'isotropic' 2) added optional argument skipGS to skip transitions to the ground state (direct peak)
mpmdean
reviewed
Jul 23, 2024
edrixs/solvers.py
Outdated
| the angle (in radians) between the linear polarization vector and the scattering plane. | ||
|
|
||
| If str1 or str2 is 'isotropic' then the scattering is considered isotropic and the other | ||
| variables are ignored. |
There was a problem hiding this comment.
along each axis and the other variables are ignored.
There was a problem hiding this comment.
Changed in the updated version.
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark <[email protected]>
if the elastic peak is ignored, the indices in gs_list are explicitly omitted from the set of final states, instead of the first len(gs_list) energy levels of eval_i.
|
Suggestions implemented along with a small additional modification: In the case |
|
I think we should go ahead and merge this One note here, is that the wheels in checks > artifacts have file names like:
I thought that the part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rixs_1v1c_py: