Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX compilation #200

Merged
merged 28 commits into from
Jun 5, 2024
Merged

Fix OSX compilation #200

merged 28 commits into from
Jun 5, 2024

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Dec 15, 2023

This PR enables publishing wheels to PyPI. At the moment we are only building Linux wheels (tested on both Ubuntu and RedHat OSs).

@mrakitin mrakitin mentioned this pull request Feb 27, 2024
@mrakitin
Copy link
Member Author

@mpmdean, I was able to produce wheels for MacOS as well, however, when trying to build the documentation with the versions, it fails on importing fedrixs. Have you ever been able to import it on MacOS (Intel x86_64 arch)?

@mpmdean
Copy link
Contributor

mpmdean commented Feb 28, 2024

Hi @mrakitin

Thanks for the progres. Yes, the current conda-forge package for edrixs can be installed and run on MacOS (Intel x86_64 arch). I just did a fresh test of this on an old mac we have here.

I have always had trouble building locally on a mac, however.

@mrakitin mrakitin closed this Jun 5, 2024
@mrakitin mrakitin reopened this Jun 5, 2024
@mrakitin mrakitin marked this pull request as ready for review June 5, 2024 21:10
@mrakitin
Copy link
Member Author

mrakitin commented Jun 5, 2024

Reviewed in-person with @mpmdean and @lajerm.

@mrakitin mrakitin merged commit 36ec565 into master Jun 5, 2024
10 checks passed
@mrakitin mrakitin deleted the fix-osx-compilation branch June 5, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants