Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix battery O&M capacity-based expense in cash flow #1076

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Fix battery O&M capacity-based expense in cash flow #1076

merged 4 commits into from
Oct 31, 2023

Conversation

cpaulgilman
Copy link
Collaborator

@cpaulgilman cpaulgilman commented Oct 27, 2023 •
edited
Loading

Fixes #1045

Battery capacity-based O&M expense should be reported in cash flow for all financial models.

SAM test file: capacity-based-expense-test-sam-2022-11-21.zip

Goes with SAM test file update: NREL/SAM#1525

@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Oct 27, 2023
@cpaulgilman cpaulgilman self-assigned this Oct 27, 2023
@cpaulgilman cpaulgilman mentioned this pull request Oct 27, 2023
Closed
brtietz
brtietz approved these changes Oct 29, 2023
View reviewed changes
Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSC changes look good. I'd recommend waiting to merge until we get a pass on the SAM PR.

sjanzou
sjanzou approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and see comment from @brtietz for NREL/SAM#1525

@cpaulgilman cpaulgilman mentioned this pull request Oct 30, 2023
Merged
@cpaulgilman
Copy link
Collaborator Author

See NREL/SAM#1532

@sjanzou sjanzou merged commit 1e23d23 into develop Oct 31, 2023
4 checks passed
@sjanzou sjanzou deleted the om-expense-cash-flow branch October 31, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanzou sjanzou sjanzou approved these changes

@brtietz brtietz brtietz approved these changes

Assignees

@cpaulgilman cpaulgilman

Labels
added to release notes
Projects
None yet
Milestone
SAM Fall 2023 Release
Development

Successfully merging this pull request may close these issues.

O&M battery capacity-based expense incorrect
3 participants
@cpaulgilman @brtietz @sjanzou