Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geothermal model updates #1075

Merged
merged 48 commits into from
Oct 30, 2023
Merged

Geothermal model updates #1075

merged 48 commits into from
Oct 30, 2023

Conversation

mjprilliman
Copy link
Collaborator

-Updates to well count, pump requirement calculations
-Updates for wet bulb temperature calculations
-Other model updates

mjprilliman and others added 30 commits March 24, 2023 09:54
@mjprilliman
Use wet bulb constant or weather file amb temp for each instance of wet
d371e78 
bulb
@sjanzou
Update to GitHub Actions to latest Ubuntu
60554d5 
Ubuntu-18.04 deprecated as of 4/2023 https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/
@sjanzou
Merge pull request #1009 from NREL/github_actions_patch
9b08216 
Update deprecated Ubuntu-18.04 runner
@mjprilliman
Initial sg2 implementation, currently debugging
5df5bf4
@mjprilliman
Commented out unused code sections, prepped for speed testing
551f8c4
@sjanzou
update ssc version for testing and benchmarking
54d10cf
@mjprilliman
Removed commented lines, update test results (irrad tests, pvwatts
8512dd6 
tests)
@mjprilliman
Updated test results
bfd3b00
@mjprilliman
Re-run PVWatts cmod tests for different DC-AC ratio, updated remaining
3ee3619 
tests
@mjprilliman
Merge pull request #1013 from NREL/sg2-implementation
8536853 
Sg2 implementation
@mjprilliman
Merge branch 'patch' into getem-wf-temp
25411ee
@mjprilliman
Use placeholder temperature for ui calc of ambient temperature
121fbd8
@mjprilliman
Merge branch 'develop' into getem-wf-temp
208e4d9
@mjprilliman
Use wet bulb for temperature, add annual_twet to wfreader
f8827c1
@mjprilliman
Updated tests
421e31b
@mjprilliman
Keep EGS default value
0ac1ac1
@mjprilliman
Updates
1297823
@mjprilliman
Update ambient / wet bulb assumptions, testing pump calcs again
4013973
@mjprilliman
Link pump sizes to drilling well diam selection
7587c6b
@mjprilliman
Update tests
ac0c477
@mjprilliman
Merge branch 'develop' into getem-wf-temp
e75d444
@sjanzou
2023.6.9.ssc.281 getem beta
4f70286
@mjprilliman
Link binary ambient temp condition to wet bulb temperature, same as
38ccb12 
flash
@mjprilliman
Merge branch 'getem-wf-temp' of https://github.com/nrel/ssc into gete…
ca71f13 
…m-wf-temp
@mjprilliman
Testing gringarten, ramey models for issues found in binary case
2c0a52f
@mjprilliman
Update default state for gringarten model (0), fix initialization of
6a0808f 
ramey wellbore to be more consistent with first month,
@mjprilliman
Begin adding om cost module
019fe35
@mjprilliman
Continued OM cost calcs
49ebe32
@mjprilliman
Added EGS well count calculations, need to test and add UI variables
dc9648f
@mjprilliman
Update injectivity of failed wells, need to add friction total
3df4845 
calculations below pump
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Oct 27, 2023
@mjprilliman mjprilliman self-assigned this Oct 27, 2023
sjanzou
sjanzou approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results look good.

sjanzou
sjanzou approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing and library and compute module changes look good.
Good that reporting annual_twet now!

@mjprilliman mjprilliman merged commit e4bed34 into develop Oct 30, 2023
4 checks passed
@mjprilliman mjprilliman deleted the getem-fixes branch October 30, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanzou sjanzou sjanzou approved these changes

@cpaulgilman cpaulgilman Awaiting requested review from cpaulgilman

Assignees

@mjprilliman mjprilliman

Labels
added to release notes
Projects
None yet
Milestone
SAM Fall 2023 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mjprilliman @sjanzou @cpaulgilman