Allow params array for qdm to be a dask array. Also make sure dset is… #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in self.h5 when getting attrs. This isn't the case if we've written a dataset like 'meta/latitude' to an h5 file.
bnb32
force-pushed
the
bnb/allow_dask_array
branch
from
840a487
to
98de327
Compare
…mplishes what we want here.
bnb32
force-pushed
the
bnb/allow_dask_array
branch
from
98de327
to
b141b93
Compare
bnb32
force-pushed
the
bnb/allow_dask_array
branch
from
7f04a72
to
94aa1b1
Compare
bnb32
force-pushed
the
bnb/allow_dask_array
branch
from
d4e4535
to
fc352da
Compare
grantbuster
approved these changes
Jul 24, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
Allow params array for qdm to be a dask array. Also make sure dset is…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in self.h5 when getting attrs. This isn't the case if we've written a dataset like 'meta/latitude' to an h5 file.