Use numpy arrays in time series #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-thom
commented
Nov 15, 2024
| """Check time series data.""" | ||
| if len(data) < 2: | ||
| msg = f"SingleTimeSeries length must be at least 2: {len(data)}" | ||
| raise ValueError(msg) | ||
|
|
||
| if isinstance(data, pint.Quantity): | ||
| if not isinstance(data.magnitude, np.ndarray): |
There was a problem hiding this comment.
Please confirm that this is correct. Previously, if the user passed a range object inside a pint Quantity, pint would leave it alone. This guarantees that SingleTimeSeries will always have numpy array.
daniel-thom
commented
Nov 15, 2024
| @@ -341,7 +352,7 @@ def from_data(cls, time_series: SingleTimeSeries, **user_attributes) -> Any: | |||
| quantity_type=type(time_series.data), | |||
| units=str(time_series.data.units), | |||
| ) | |||
| if isinstance(time_series.data, BaseQuantity) | |||
| if isinstance(time_series.data, pint.Quantity) | |||
There was a problem hiding this comment.
@pesap This fixes the Quantity vs BaseQuantity issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 95.24% 95.04% -0.21%
==========================================
Files 33 33
Lines 2778 2807 +29
==========================================
+ Hits 2646 2668 +22
- Misses 132 139 +7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pesap
approved these changes
Nov 18, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Use numpy arrays in time series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously storing time series arrays as pyarrow arrays. That was causing complexity because users often need numpy arrays. The team decided to convert them to numpy arrays straightaway instead.
I also upgraded mypy and fixed some errors caused by that upgrade.
Fixes #54