Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #72

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Minor cleanup #72

merged 4 commits into from
Dec 13, 2024

Conversation

malihass
Copy link
Collaborator

  • Remove useless output folders
  • Improve exception handling
  • Use PBE for loop reactor mixing so that d.gas can be printed

@malihass malihass requested a review from hsitaram December 11, 2024 15:10
@malihass malihass requested a review from fmuni December 11, 2024 15:11
fmuni
fmuni approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@fmuni fmuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@fmuni fmuni merged commit dcd1d55 into main Dec 13, 2024
10 checks passed
@malihass malihass deleted the cleanup branch December 13, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuni fmuni fmuni approved these changes

@hsitaram hsitaram Awaiting requested review from hsitaram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malihass @fmuni