Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.9 + tutorial and experimental tested in CI #66

Merged
merged 27 commits into from
Dec 9, 2024
Merged

Support python 3.9 + tutorial and experimental tested in CI #66

merged 27 commits into from
Dec 9, 2024

Conversation

malihass
Copy link
Collaborator

@malihass malihass commented Dec 3, 2024 •
edited
Loading

  • Support python 3.9 since numpyro 0.16.1 so it closes Support python 3.9? #65
  • Separate BiRD and OF tests
  • Bump up the action version from v3 to v4
  • Stirred tank instead of stir tank

List of tutorial cases to add closes #67

  • block cylindrical sparger case (probably the side sparger)
  • bubble column with projected circle and no disengagement
  • Loop reactor
  • stirred tank reactor
  • Loop reactor with reaction driver

List of experimental cases to add

  • Deckwer case

@malihass malihass marked this pull request as draft December 6, 2024 15:32
@malihass malihass marked this pull request as ready for review December 7, 2024 00:14
@malihass malihass changed the title update action version and test for python 3.9 Support python 3.9 + tutorial and experimental tested in CI Dec 7, 2024
@malihass malihass requested review from fmuni and hsitaram December 7, 2024 23:37
fmuni
fmuni approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@fmuni fmuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok to me!

@malihass malihass merged commit 4522199 into main Dec 9, 2024
10 checks passed
@malihass malihass deleted the ofaction branch December 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuni fmuni fmuni approved these changes

@hsitaram hsitaram hsitaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github action for testing openfoam tutorials Support python 3.9?
3 participants
@malihass @hsitaram @fmuni