Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dsc/cleanup #51

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Dsc/cleanup #51

merged 8 commits into from
Dec 26, 2024

Conversation

scdhulipala
Copy link
Contributor

@scdhulipala scdhulipala commented Dec 23, 2024

1.Thanks for opening a PR to SiennaPRASInterface.jl, please take note of the following when making a PR:

Check the contributor guidelines

  • Remove using specific load type and use StaticLoad when calculating region load time series data
  • Keep track of time series resolution and step to build PRAS System if the resolution < Hour(1)
  • Remove avaialability kwarg
  • Include tests for sub-hourly Systems
  • Remove current lumping logic and replace with component map. Also remove lump_region_renewable_gen kwarg.
  • Fix PRAS2PowerSystems.jl bugs.

Copy link
Collaborator

@josephmckinsey josephmckinsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need test data for a < 1 hour system, otherwise I would request we add that now. Removing availability is the most important part here.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.07%. Comparing base (77b8603) to head (579d219).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/PRAS2PowerSystems.jl 0.00% 2 Missing ⚠️
src/PowerSystems2PRAS.jl 93.75% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   50.45%   47.07%   -3.38%     
==========================================
  Files          54       12      -42     
  Lines        3201      752    -2449     
==========================================
- Hits         1615      354    -1261     
+ Misses       1586      398    -1188     
Flag Coverage Δ
unittests 47.07% <86.95%> (-3.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SiennaPRASInterface.jl 100.00% <100.00%> (ø)
src/util/parsing/PRAS_export.jl 83.33% <100.00%> (ø)
src/util/parsing/Sienna_PRAS_metadata.jl 55.55% <ø> (ø)
src/util/parsing/lines_and_interfaces.jl 100.00% <100.00%> (ø)
src/PowerSystems2PRAS.jl 81.59% <93.75%> (+0.06%) ⬆️
src/PRAS2PowerSystems.jl 0.00% <0.00%> (ø)

@scdhulipala scdhulipala marked this pull request as draft December 24, 2024 16:55
@scdhulipala scdhulipala marked this pull request as ready for review December 24, 2024 22:15
@scdhulipala scdhulipala merged commit 635372d into main Dec 26, 2024
8 checks passed
@josephmckinsey josephmckinsey deleted the dsc/cleanup branch December 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants