Parse missing sw shunt data in psse.jl file #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Dec 17, 2024
src/parsers/pm_io/psse.jl
Outdated
| @@ -344,7 +344,7 @@ for Switched Shunts, as given by the PSS(R)E Fixed and Switched Shunts | |||
| specifications. | |||
| """ | |||
| function _psse2pm_shunt!(pm_data::Dict, pti_data::Dict, import_all::Bool) | |||
| @info "Parsing PSS(R)E Shunt data into a PowerModels Dict..." | |||
| @info "Parsing PSS(R)E Shunt data into a PowerxModels Dict..." | |||
There was a problem hiding this comment.
This seems to be an undesired change
There was a problem hiding this comment.
Sorry, a misstep on the keyboard. I've already fix it.
jd-lara
requested changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3WTransformer #1230 +/- ##
================================================
Coverage ? 84.29%
================================================
Files ? 181
Lines ? 8391
Branches ? 0
================================================
Hits ? 7073
Misses ? 1318
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@mcllerena you need to run the formatter |
jd-lara
requested changes
Dec 26, 2024
There was a problem hiding this comment.
@mcllerena this looks good to me. We need to add a case for testing this code and also add the code to read this data into the SwtichedShunt structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding missing parameters "VSWHI" (upper_limit), "VSWLO" (lower limit), Bi (admittance increment) & Ni (number of steps), to the function _psse2pm_shunt!.