Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unique_timestamps option for post processing #384

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

m-bossart
Copy link
Collaborator

Default behavior (unique_timestamps = true) remains unchanged; repeated timestamps are filtered to match existing simulation tools.
This allows the user to keep repeated timestamps if desired.

Copy link
Contributor

Performance Results

Version Precompile Time
Main 1.874199679
This Branch 1.847634864
Version Run Time
Main-Build ResidualModel 7.659833109
Main-Execute ResidualModel 16.329347244
Main-Build MassMatrixModel 0.610692504
Main-Execute MassMatrixModel 30.576796056
This Branch-Build ResidualModel 7.783258734
This Branch-Execute ResidualModel 16.278808354
This Branch-Build MassMatrixModel 0.611902145
This Branch-Execute MassMatrixModel 30.108783895

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. @jd-lara We should merge this as it will change some API of new models.

@jd-lara jd-lara merged commit ce0ab1c into main Oct 18, 2024
6 of 7 checks passed
@jd-lara jd-lara deleted the mb/unique_timestamps branch October 18, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants