Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in docs for droop constructor #374

Merged
merged 1 commit into from
Apr 9, 2024
Merged

typo in docs for droop constructor #374

merged 1 commit into from
Apr 9, 2024

Conversation

m-bossart
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Performance Results

Version Precompile Time
Main 1.858573126
This Branch 1.881966552
Version Run Time
Main-Build ResidualModel 7.555431048
Main-Execute ResidualModel 16.78531746
Main-Build MassMatrixModel 0.611762161
Main-Execute MassMatrixModel 31.551926987
This Branch-Build ResidualModel 6.592608001
This Branch-Execute ResidualModel 16.586946918
This Branch-Build MassMatrixModel 0.589223917
This Branch-Execute MassMatrixModel 30.459402578

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (6a070cb) to head (14470bc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   87.56%   87.34%   -0.22%     
==========================================
  Files          65       65              
  Lines        9156     9143      -13     
==========================================
- Hits         8017     7986      -31     
- Misses       1139     1157      +18     
Flag Coverage Δ
unittests 87.34% <ø> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@jd-lara jd-lara requested a review from rodrigomha April 5, 2024 21:45
@rodrigomha rodrigomha merged commit d5a8630 into main Apr 9, 2024
9 checks passed
@jd-lara jd-lara deleted the mb/small-docs-fix branch May 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants