Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inner vars indexing bug #371

Merged
merged 1 commit into from
Mar 27, 2024
Merged

inner vars indexing bug #371

merged 1 commit into from
Mar 27, 2024

Conversation

m-bossart
Copy link
Collaborator

When creating the range for inner vars for dynamic injectors, the ranges for distinct devices are overlapped by one. The tests still pass because in practice the first/last inner var for certain devices could be unused.

Copy link
Contributor

Performance Results

Version Precompile Time
Main 1.830861056
This Branch 1.813680774
Version Run Time
Main-Build ResidualModel 7.6167594
Main-Execute ResidualModel 16.968434252
Main-Build MassMatrixModel 0.630960818
Main-Execute MassMatrixModel 30.778520708
This Branch-Build ResidualModel 7.573532119
This Branch-Execute ResidualModel 16.499326563
This Branch-Build MassMatrixModel 0.713582085
This Branch-Execute MassMatrixModel 30.890439285

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base (3f9dede) to head (53c4c3d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   87.18%   87.30%   +0.11%     
==========================================
  Files          65       65              
  Lines        9069     9003      -66     
==========================================
- Hits         7907     7860      -47     
+ Misses       1162     1143      -19     
Flag Coverage Δ
unittests 87.30% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/simulation_inputs.jl 92.85% <ø> (ø)

... and 11 files with indirect coverage changes

@jd-lara jd-lara self-assigned this Mar 27, 2024
@jd-lara jd-lara merged commit 29583de into main Mar 27, 2024
9 checks passed
@jd-lara jd-lara deleted the mb/inner-vars-bug branch May 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants