Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post processing functions return Vector{Float64} #368

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Conversation

m-bossart
Copy link
Collaborator

The post processing functions did not return Vector{Float64} when dt was passed. This makes the output the same regardless of dt being specified or not.

@m-bossart m-bossart requested a review from jd-lara March 8, 2024 23:02
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Performance Results

Version Precompile Time
Main 1.785499261
This Branch 1.78848536
Version Execute Time
Main-Build ResidualModel 7.421300981
Main-Execute ResidualModel 16.030765402
Main-Build MassMatrixModel 0.654075383
Main-Execute MassMatrixModel 30.191749787
This Branch-Build ResidualModel 7.453312533
This Branch-Execute ResidualModel 16.109242247
This Branch-Build MassMatrixModel 0.654555026
This Branch-Execute MassMatrixModel 30.397058236

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (3f9dede) to head (01c4cf0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   86.98%   87.32%   +0.34%     
==========================================
  Files          65       65              
  Lines        9052     9003      -49     
==========================================
- Hits         7874     7862      -12     
+ Misses       1178     1141      -37     
Flag Coverage Δ
unittests 87.32% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/simulation_results.jl 68.34% <100.00%> (ø)

... and 8 files with indirect coverage changes

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't double collect

@m-bossart m-bossart requested a review from jd-lara March 16, 2024 13:24
@jd-lara jd-lara merged commit 6eda891 into main Mar 29, 2024
9 checks passed
@jd-lara jd-lara deleted the mb/post-process-fix branch May 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants