Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mb/add degov3 #366

Merged
merged 6 commits into from
Mar 29, 2024
Merged

Mb/add degov3 #366

merged 6 commits into from
Mar 29, 2024

Conversation

m-bossart
Copy link
Collaborator

adds DEGOV model and capability of adding time delays to massmatrix formulation.

m-bossart and others added 2 commits January 5, 2024 11:34
* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* work in progress (add delays)

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* fix jacobian change

* scimlbase 2

* remove repeated function
Copy link
Contributor

github-actions bot commented Jan 30, 2024

Performance Results

Version Precompile Time
Main 1.778379186
This Branch 1.772889415
Version Execute Time
Main-Build ResidualModel 7.201907492
Main-Execute ResidualModel 16.007409478
Main-Build MassMatrixModel 0.909589472
Main-Execute MassMatrixModel 29.836048534
This Branch-Build ResidualModel 7.160060935
This Branch-Execute ResidualModel 16.030471456
This Branch-Build MassMatrixModel 0.596852785
This Branch-Execute MassMatrixModel 30.101329358

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: Patch coverage is 89.37500% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 87.37%. Comparing base (73a7147) to head (db3638c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   87.40%   87.37%   -0.04%     
==========================================
  Files          65       65              
  Lines        8999     9143     +144     
==========================================
+ Hits         7866     7989     +123     
- Misses       1133     1154      +21     
Flag Coverage Δ
unittests 87.37% <89.37%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/device_wrapper.jl 87.50% <100.00%> (+0.11%) ⬆️
src/base/nlsolve_wrapper.jl 63.00% <100.00%> (+1.14%) ⬆️
src/base/simulation.jl 94.54% <100.00%> (+1.24%) ⬆️
src/base/simulation_inputs.jl 93.17% <100.00%> (+0.31%) ⬆️
src/base/small_signal.jl 87.58% <100.00%> (+0.16%) ⬆️
src/base/system_model.jl 100.00% <100.00%> (ø)
src/initialization/generator_components/init_tg.jl 95.78% <100.00%> (+0.30%) ⬆️
src/models/device.jl 94.69% <100.00%> (ø)
src/models/generator_models/avr_models.jl 99.08% <ø> (ø)
src/models/generator_models/machine_models.jl 100.00% <ø> (ø)
... and 12 more

... and 7 files with indirect coverage changes

@m-bossart
Copy link
Collaborator Author

opened a new PR to resolve test dependency issue

Project.toml Outdated Show resolved Hide resolved
src/base/device_wrapper.jl Outdated Show resolved Hide resolved
src/base/device_wrapper.jl Outdated Show resolved Hide resolved
src/base/simulation.jl Outdated Show resolved Hide resolved
@m-bossart m-bossart requested a review from jd-lara February 5, 2024 23:33
@jd-lara jd-lara merged commit 6a070cb into main Mar 29, 2024
9 checks passed
@jd-lara jd-lara deleted the mb/add-degov3 branch May 9, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants