Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access solution at arbitrary vector of times #365

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

m-bossart
Copy link
Collaborator

Expands the interface to allow for passing a vector of times instead of simply a fixed dt or nothing which returns the solution timesteps.

Copy link
Contributor

Performance Results

Version Precompile Time
Main 2.010416449
This Branch 2.093336906
Version Run Time
Main-Build ResidualModel 7.615302268
Main-Execute ResidualModel 19.276766833
Main-Build MassMatrixModel 0.953146199
Main-Execute MassMatrixModel 31.553906815
This Branch-Build ResidualModel 6.750129131
This Branch-Execute ResidualModel 19.786375174
This Branch-Build MassMatrixModel 0.610223887
This Branch-Execute MassMatrixModel 31.742519336

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10c54fa) 86.99% compared to head (878528c) 87.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   86.99%   87.39%   +0.40%     
==========================================
  Files          65       65              
  Lines        9048     9003      -45     
==========================================
- Hits         7871     7868       -3     
+ Misses       1177     1135      -42     
Flag Coverage Δ
unittests 87.39% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/simulation_results.jl 68.34% <100.00%> (+0.59%) ⬆️
src/post_processing/post_proc_generator.jl 89.70% <ø> (ø)
src/post_processing/post_proc_inverter.jl 93.38% <100.00%> (ø)
src/post_processing/post_proc_loads.jl 97.19% <ø> (ø)
src/post_processing/post_proc_source.jl 65.00% <ø> (ø)

... and 4 files with indirect coverage changes

@m-bossart m-bossart requested a review from rodrigomha January 31, 2024 14:30
@jd-lara jd-lara merged commit 3f19c72 into main Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants