Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DEGOV (#357) #362

Closed
wants to merge 2 commits into from
Closed

add DEGOV (#357) #362

wants to merge 2 commits into from

Conversation

m-bossart
Copy link
Collaborator

adds DEGOV model and capability of adding time delays to massmatrix formulation.

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* work in progress (add delays)

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* fix jacobian change

* scimlbase 2

* remove repeated function
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Performance Results

Version Precompile Time
Main 2.02683557
This Branch 2.063898738
Version Execute Time
Main-Build ResidualModel 7.346802618
Main-Execute ResidualModel 19.51024517
Main-Build MassMatrixModel 0.61421815
Main-Execute MassMatrixModel 31.725576972
This Branch-Build ResidualModel 7.727489063
This Branch-Execute ResidualModel 19.622980931
This Branch-Build MassMatrixModel 0.625091172
This Branch-Execute MassMatrixModel 31.777282267

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (73a7147) 87.40% compared to head (370aed8) 87.42%.
Report is 1 commits behind head on main.

❗ Current head 370aed8 differs from pull request most recent head 658c393. Consider uploading reports for the commit 658c393 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   87.40%   87.42%   +0.01%     
==========================================
  Files          65       65              
  Lines        8999     9140     +141     
==========================================
+ Hits         7866     7991     +125     
- Misses       1133     1149      +16     
Flag Coverage Δ
unittests 87.42% <89.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/device_wrapper.jl 87.50% <100.00%> (+0.11%) ⬆️
src/base/nlsolve_wrapper.jl 63.00% <100.00%> (+1.14%) ⬆️
src/base/simulation.jl 94.54% <100.00%> (+1.24%) ⬆️
src/base/simulation_inputs.jl 93.20% <100.00%> (+0.34%) ⬆️
src/base/small_signal.jl 87.58% <100.00%> (+0.16%) ⬆️
src/base/system_model.jl 100.00% <100.00%> (ø)
src/initialization/generator_components/init_tg.jl 95.78% <100.00%> (+0.30%) ⬆️
src/models/device.jl 94.38% <100.00%> (-0.32%) ⬇️
src/models/generator_models/avr_models.jl 99.08% <ø> (ø)
src/models/generator_models/machine_models.jl 100.00% <ø> (ø)
... and 12 more

... and 1 file with indirect coverage changes

@jd-lara jd-lara requested review from jd-lara and rodrigomha January 5, 2024 19:15
@jd-lara jd-lara self-assigned this Jan 5, 2024
@m-bossart m-bossart closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants