Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DEGOV #357

Merged
merged 39 commits into from
Jan 5, 2024
Merged

add DEGOV #357

merged 39 commits into from
Jan 5, 2024

Conversation

m-bossart
Copy link
Collaborator

Add DEGOV for purpose of validating inclusion of delays

@m-bossart m-bossart marked this pull request as ready for review December 15, 2023 22:51
@m-bossart m-bossart requested a review from jd-lara December 15, 2023 22:51
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Performance Results

Version Precompile Time
Main 1.935807535
This Branch 1.917305793
Version Execute Time
Main-Build ResidualModel 7.411600575
Main-Execute ResidualModel 18.010944366
Main-Build MassMatrixModel 0.880854672
Main-Execute MassMatrixModel 29.986483617
This Branch-Build ResidualModel 7.451869459
This Branch-Execute ResidualModel 18.746235537
This Branch-Build MassMatrixModel 0.601160119
This Branch-Execute MassMatrixModel 29.937113738

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (4a7cca9) 87.01% compared to head (f336ece) 87.49%.
Report is 5 commits behind head on main.

❗ Current head f336ece differs from pull request most recent head 8fdaa22. Consider uploading reports for the commit 8fdaa22 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   87.01%   87.49%   +0.47%     
==========================================
  Files          65       65              
  Lines        9048     9137      +89     
==========================================
+ Hits         7873     7994     +121     
+ Misses       1175     1143      -32     
Flag Coverage Δ
unittests 87.49% <91.25%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/device_wrapper.jl 87.50% <100.00%> (+0.11%) ⬆️
src/base/frequency_reference.jl 88.23% <ø> (ø)
src/base/nlsolve_wrapper.jl 63.00% <100.00%> (+1.14%) ⬆️
src/base/simulation.jl 94.54% <100.00%> (+1.18%) ⬆️
src/base/simulation_initialization.jl 83.13% <100.00%> (ø)
src/base/simulation_inputs.jl 93.20% <100.00%> (+0.34%) ⬆️
src/base/small_signal.jl 87.58% <100.00%> (+0.16%) ⬆️
src/base/system_model.jl 100.00% <100.00%> (ø)
src/initialization/generator_components/init_tg.jl 95.78% <100.00%> (+0.30%) ⬆️
.../initialization/inverter_components/init_DCside.jl 100.00% <ø> (ø)
... and 20 more

... and 3 files with indirect coverage changes

@jd-lara jd-lara changed the base branch from main to mb/add-degov2 January 5, 2024 18:34
@jd-lara jd-lara merged commit 370aed8 into mb/add-degov2 Jan 5, 2024
5 of 6 checks passed
jd-lara added a commit that referenced this pull request Mar 29, 2024
* add DEGOV (#357)

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* add degov

* work in progress (add delays)

* add docstring for small_signal_analysis

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* work in progress (add delays)

* add simple docs page

* add more docs

* more changes

* add bus_size to DW

* fix test in base

* update Project.toml

* Revert "update Project.toml"

This reverts commit 376c895.

* get delays as a vector

* fix jacobian change

* scimlbase 2

* remove repeated function

* update Project

* add type to delay

Co-authored-by: Jose Daniel Lara <[email protected]>

* add type SimulationInputs

* fix type

* remove bus_size

---------

Co-authored-by: Jose Daniel Lara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants