-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes #273
bug fixes #273
Conversation
Performance Results
ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 89.96% 90.60% +0.63%
==========================================
Files 65 64 -1
Lines 7113 7064 -49
==========================================
+ Hits 6399 6400 +1
+ Misses 714 664 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The additional coverage is done in #274 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We may want in the future add a test that reset the simulation by running the same execute two times.
closes #271
closes #146
It also closes an issue with simulation reset that wasn't working correctly