Add ComponentSelector feature: PSI portion
#1196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to and dependent on
ComponentSelectorfeature: IS portion InfrastructureSystems.jl#342ComponentSelectorfeature: PSY portion (take two) PowerSystems.jl#1197. The main thing here is we want
get_componentsto work onIS.Resultssuch thatget_componentson aResultsis likeget_available_componentson its attachedSystem(or attachedIS.SystemData, etc.). The implementation of this behavior is in the IS PR, but following the design set out here, we need to definePSY.get_componentsaliases that redirect to the appropriateIS.get_componentsmethods to keep the documentation user-friendly. That cannot be done in IS and (correct me if I'm wrong) it doesn't really make sense to do in PSY, so it is done here.