Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market bid cost with pwl cost curve #1182

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Market bid cost with pwl cost curve #1182

wants to merge 10 commits into from

Conversation

purboday
Copy link

@purboday purboday commented Dec 9, 2024

  1. In src/devices_models/devices/common/objective_function/market_bid.jl added function _add_vom_cost_to_objective!.
  2. Updated "Test Thermal Generation MarketBidCost models" in test/test_device_thermal_generation_constructors.jl to make fixed_market_bid_cost run and pass.
  3. Other diffs caused by the formatter.

jd-lara
jd-lara reviewed Dec 11, 2024
View reviewed changes
test/run_market_bid_cost.jl Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is useful but it shouldn't be checked out into the repo. I'd like the original test to be fixed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd-lara jd-lara jd-lara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purboday @jd-lara @rodrigomha