Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use service name in meta #1172

Merged
merged 1 commit into from
Nov 8, 2024
Merged

use service name in meta #1172

merged 1 commit into from
Nov 8, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Nov 8, 2024

this is required to fix the HSS code

@jd-lara jd-lara requested a review from rodrigomha November 8, 2024 19:33
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait for the tests though

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (01a1bc6) to head (75d6017).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files         121      121           
  Lines       13089    13089           
=======================================
  Hits        10000    10000           
  Misses       3089     3089           
Flag Coverage Δ
unittests 76.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...devices_models/devices/common/add_to_expression.jl 73.21% <ø> (ø)

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Performance Results

Version Precompile Time
Main 4.037146898
This Branch 4.043913558
Version Build Time
Main-Build Time Precompile 66.72114702
Main-Build Time Postcompile 0.955002617
This Branch-Build Time Precompile 64.444036681
This Branch-Build Time Postcompile 0.96378275
Version Solve Time
Main-Solve Time Precompile 976.285590581
Main-Solve Time Postcompile 943.458804176
This Branch-Solve Time Precompile 388.411963386
This Branch-Solve Time Postcompile 348.370390662

@rodrigomha rodrigomha merged commit 22254f0 into main Nov 8, 2024
11 checks passed
@jd-lara jd-lara deleted the jd/fix_service_meta branch December 12, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants