Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unbounded HVDC model for Copperplate #1159

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

rodrigomha
Copy link
Contributor

Closes #1156

@rodrigomha rodrigomha requested a review from jd-lara October 10, 2024 22:19
@rodrigomha rodrigomha self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (2095cf1) to head (7002474).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s_models/device_constructors/branch_constructor.jl 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   76.44%   76.40%   -0.05%     
==========================================
  Files         121      121              
  Lines       13082    13090       +8     
==========================================
  Hits        10001    10001              
- Misses       3081     3089       +8     
Flag Coverage Δ
unittests 76.40% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s_models/device_constructors/branch_constructor.jl 77.87% <0.00%> (-1.89%) ⬇️

Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.343728126
This Branch 4.334466012
Version Build Time
Main-Build Time Precompile 63.770092196
Main-Build Time Postcompile 1.023832742
This Branch-Build Time Precompile 63.685154602
This Branch-Build Time Postcompile 1.082367823
Version Solve Time
Main-Solve Time Precompile 1181.874252909
Main-Solve Time Postcompile 1149.965103891
This Branch-Solve Time Precompile 862.11565947
This Branch-Solve Time Postcompile 823.881712713

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add a test for this to avoid from it happening in the future.

@jd-lara jd-lara merged commit a0626bb into main Oct 11, 2024
7 of 11 checks passed
@jd-lara jd-lara deleted the rh/fix_unbounded_hvdc_model branch October 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HVDCTwoTerminalUnbounded does not add variables for Copperplate with multiple subnetworks
2 participants