Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect getter #1158

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix incorrect getter #1158

merged 1 commit into from
Oct 10, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Oct 10, 2024

closes #1157

@jd-lara jd-lara requested a review from rodrigomha October 10, 2024 17:05
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (fdde35f) to head (dc907c7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files         121      121           
  Lines       13082    13082           
=======================================
  Hits        10001    10001           
  Misses       3081     3081           
Flag Coverage Δ
unittests 76.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/devices_models/devices/thermal_generation.jl 84.60% <100.00%> (ø)

@jd-lara jd-lara merged commit 2095cf1 into main Oct 10, 2024
8 of 11 checks passed
Copy link
Contributor

Performance Results

Version Precompile Time
Main 4.27894185
This Branch 4.874214857
Version Build Time
Main-Build Time Precompile 60.969414802
Main-Build Time Postcompile 1.040114499
This Branch-Build Time Precompile 72.105397944
This Branch-Build Time Postcompile 1.017707404
Version Solve Time
Main-Solve Time Precompile 700.118614043
Main-Solve Time Postcompile 671.951397296
This Branch-Solve Time Precompile 1373.5349967
This Branch-Solve Time Postcompile 1342.917263493

@jd-lara jd-lara deleted the jd/fix_reactive_power_bounds branch October 24, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive power incorrect bounds
2 participants