Export opt model setting #1141
Merged
Export opt model setting #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigomha
reviewed
Sep 11, 2024
IMO is fine, serialize is not exported. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
==========================================
+ Coverage 77.89% 77.93% +0.03%
==========================================
Files 118 118
Lines 12700 12707 +7
==========================================
+ Hits 9893 9903 +10
+ Misses 2807 2804 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
daniel-thom
reviewed
Sep 11, 2024
|
|
||
| if get_export_optimization_model(get_settings(model)) | ||
| model_output_dir = joinpath(output_dir, "optimization_model_exports") | ||
| if !ispath(model_output_dir) |
There was a problem hiding this comment.
In case you care, this is slightly more convenient.
Suggested change
| if !ispath(model_output_dir) | |
| mkpath(model_output_dir) |
daniel-thom
approved these changes
Sep 11, 2024
rodrigomha
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.