Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change error checking #1131

Merged
merged 3 commits into from
Aug 20, 2024
Merged

change error checking #1131

merged 3 commits into from
Aug 20, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Aug 8, 2024

No description provided.

@jd-lara jd-lara requested a review from rodrigomha August 8, 2024 18:48
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.43%. Comparing base (2334364) to head (7314623).
Report is 561 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
- Coverage   80.89%   77.43%   -3.46%     
==========================================
  Files         115      118       +3     
  Lines       12533    12659     +126     
==========================================
- Hits        10138     9803     -335     
- Misses       2395     2856     +461     
Flag Coverage Δ
unittests 77.43% <100.00%> (-3.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/parameters/update_parameters.jl 26.46% <100.00%> (-18.07%) ⬇️

... and 86 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Performance Results

Version Precompile Time
Main 3.161692616
This Branch 3.231809433
Version Build Time
Main-Build Time Precompile 49.959471536
Main-Build Time Postcompile 1.052277354
This Branch-Build Time Precompile 50.822371986
This Branch-Build Time Postcompile 1.202377867
Version Build Time
Main-Solve Time Precompile 683.28076643
Main-Solve Time Postcompile 657.999549304
This Branch-Solve Time Precompile 667.3154191
This Branch-Solve Time Postcompile 640.484474278

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jd-lara jd-lara merged commit 5b79ebb into main Aug 20, 2024
7 checks passed
@jd-lara jd-lara deleted the jd/assertion_issue branch August 20, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants