Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/decomposition support #1123

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Jd/decomposition support #1123

merged 4 commits into from
Jul 10, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jul 9, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Performance Results

Version Precompile Time
Main 3.314010162
This Branch 3.258830411
Version Build Time
Main-Build Time Precompile 51.338806847
Main-Build Time Postcompile 1.065606281
This Branch-Build Time Precompile 50.611564307
This Branch-Build Time Postcompile 1.168426532
Version Build Time
Main-Solve Time Precompile 412.91777856
Main-Solve Time Postcompile 389.442989736
This Branch-Solve Time Precompile 450.915170113
This Branch-Solve Time Postcompile 423.509036796

@jd-lara jd-lara requested a review from GabrielKS July 9, 2024 22:05
@jd-lara jd-lara marked this pull request as ready for review July 9, 2024 22:05
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.44%. Comparing base (9d57c09) to head (933ea53).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   77.44%   77.44%           
=======================================
  Files         118      118           
  Lines       12648    12658   +10     
=======================================
+ Hits         9795     9803    +8     
- Misses       2853     2855    +2     
Flag Coverage Δ
unittests 77.44% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/core/expressions.jl 76.92% <100.00%> (+4.19%) ⬆️
src/core/optimization_container.jl 75.43% <72.72%> (-0.01%) ⬇️

@jd-lara jd-lara requested a review from rodrigomha July 10, 2024 17:51
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Not sure what of this is about decomposition support though

@jd-lara jd-lara merged commit 303c2d9 into main Jul 10, 2024
9 checks passed
@jd-lara jd-lara deleted the jd/decomposition_support branch July 17, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants