Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Interface Test and Docs Deploy #1122

Merged
merged 13 commits into from
Jul 9, 2024
Merged

Fix Interface Test and Docs Deploy #1122

merged 13 commits into from
Jul 9, 2024

Conversation

rodrigomha
Copy link
Contributor

No description provided.

@rodrigomha rodrigomha requested a review from jd-lara July 8, 2024 23:59
@rodrigomha rodrigomha marked this pull request as ready for review July 9, 2024 00:05
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.44%. Comparing base (8be4a70) to head (c10d201).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   77.00%   77.44%   +0.43%     
==========================================
  Files         118      118              
  Lines       12642    12648       +6     
==========================================
+ Hits         9735     9795      +60     
+ Misses       2907     2853      -54     
Flag Coverage Δ
unittests 77.44% <83.33%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...devices_models/devices/common/add_to_expression.jl 78.03% <ø> (ø)
src/operation/emulation_model.jl 86.00% <100.00%> (ø)
src/services_models/transmission_interface.jl 83.33% <100.00%> (+44.87%) ⬆️
src/utils/printing.jl 64.70% <100.00%> (ø)
src/simulation/simulation.jl 82.94% <0.00%> (-0.14%) ⬇️

... and 4 files with indirect coverage changes

@jd-lara jd-lara self-requested a review July 9, 2024 01:36
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as soon as the tests pass we can merge

@jd-lara jd-lara merged commit fecb592 into main Jul 9, 2024
8 of 9 checks passed
@jd-lara jd-lara deleted the rh/fix_interface_test branch July 9, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants