Ignore known-benign extraneous files in simulation results #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
changed the base branch from
rh/psy4_renaming
to
jd/area_balance_network_models
jd-lara
approved these changes
Jun 24, 2024
daniel-thom
reviewed
Jun 24, 2024
| @@ -1,6 +1,7 @@ | |||
| function check_folder_integrity(folder::String) | |||
| folder_files = readdir(folder) | |||
| alien_files = setdiff(folder_files, KNOWN_SIMULATION_PATHS) | |||
| alien_files = filter(x -> !any(occursin.(IGNORABLE_FILES, x)), alien_files) | |||
There was a problem hiding this comment.
This has caused complaints for years. Who cares if there are extra files in the directory? Can we remove this altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got tired of these warnings:
and we should aim to eliminate warnings that cry wolf. Here I add a list of regexes similar to a
.gitignorethat represent files we know it is safe to ignore.Happy to cherry-pick and set the base branch to something else, this was the most standard-looking branch I could find that actually compiles with PSY4.