-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build in parallel test #1092
Merged
Merged
build in parallel test #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * formatter --------- Co-authored-by: alefcastelli <[email protected]>
Co-authored-by: lpstreitmatter <[email protected]>
The refactor is not done yet and tests are not passing, but to proceed with the refactor I need to make a decision that I'd like to be able to easily revert if it ends up being the wrong one. Done so far: - Update documentation given FunctionData - Update all VariableCosts to refer to FunctionData - Update most cost-looking tuples to FunctionData Not done: - `moi_tests` still fail - There is still a conflict in the typing of the data stored in parameter containers - Probably more issues I haven't gotten to in the tests yet
Variable Cost Refactor Part 2: PowerSimulations
…me-series Serialize System components to HDF5
Jd/psi decompositionv3
Now passes PowerSimulations tests with `psy4`.
…IIP/PowerSimulations.jl into jd/parallel_build_testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases the solve time because of the change to HiGHS 1.7 which is slower for the UC problem than 1.1. And some numerical tolerances changes.