Initial Conditions Reconciliation #1: Detect Mismatches #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * add requires_reconciliation trait * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * add place holders * afc/created test for ic * afc/added functions on PSI for ic reconciliation * afc/fixed rounding, tested Still getting the same error as before on T=7 * formatter --------- Co-authored-by: alefcastelli <[email protected]>
Co-authored-by: lpstreitmatter <[email protected]>
jd-lara
requested changes
Mar 4, 2024
|
@GabrielKS I changed the base to go to PSY4 |
|
@jd-lara marking this as ready for review now — how does the current set of |
|
@GabrielKS can you fix the conflicts please |
jd-lara
reviewed
Mar 14, 2024
jd-lara
reviewed
Mar 14, 2024
jd-lara
reviewed
Mar 14, 2024
jd-lara
reviewed
Mar 14, 2024
Now passes PowerSimulations tests with `psy4`.
|
Fixed the merge conflicts, made the tests pass in |
jd-lara
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we implement the logic to automatically detect mismatches between initial conditions that
requires_reconciliation. Some notes about the implementation:requires_reconciliationfigures in: first we make the set of allICKeys to check, then as we are looping over them to check them we skip those whoseT::InitialConditionTypehasrequires_reconciliation(T) == false, so keys that don't require reconciliation never get compared across models even if other keys do require reconciliation. At one point we discussed comparing all the keys if at least onerequires_reconciliation; this is not that. This behavior (coupled with erring on the side ofrequires_reconciliation(T) == true) makes the most sense to me — if a key is at all relevant during this process we should just mark it as requiring reconciliation — but that should be reviewed.requires_reconciliationmethods before this draft PR becomes ready for review, I'd love to get @lpstreitmatter and José David's input on that.@infofor each mismatch, then if there are nonzero mismatches we report a@warnnoting that there is not yet logic to resolve the mismatch.