Serialize System components to HDF5 #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
daniel-thom
commented
Feb 26, 2024
| @@ -704,3 +730,26 @@ end | |||
| test_simulation_results(file_path, export_path; in_memory = in_memory) | |||
| end | |||
| end | |||
|
|
|||
| @testset "Test simulation results with system from store" begin | |||
There was a problem hiding this comment.
The changes in this file are minor. I had to shuffle things around so that I could test the new code here.
GabrielKS
requested changes
Feb 28, 2024
jd-lara
approved these changes
Feb 29, 2024
|
@daniel-thom run the formatter to merge |
daniel-thom
force-pushed
the
serialize-everything-but-time-series
branch
from
4029b78 to
6ff0a6f
Compare
Done |
daniel-thom
added a commit
that referenced
this pull request
Mar 6, 2024
daniel-thom
added a commit
that referenced
this pull request
Mar 6, 2024
jd-lara
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective: The simulations postprocessing code in PowerAnalytics.jl needs to have access to the systems used by the simulations. Those systems are not serialized if the user opts out of that feature. Ensure that these are always available.
This is the PowerSimulations portion of the solution. I added comparable branches in PowerSystems.jl and InfrastructureSystems.jl. Let me know if the interfaces here meet your needs and then I’ll open sibling PRs.