-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand get_decision_problem_results with kwargs #1060
Expand get_decision_problem_results with kwargs #1060
Conversation
Performance Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## psy4 #1060 +/- ##
==========================================
+ Coverage 80.48% 80.52% +0.04%
==========================================
Files 115 115
Lines 12403 12411 +8
==========================================
+ Hits 9982 9994 +12
+ Misses 2421 2417 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
) | ||
@test !isnothing(PSI.get_system(results_ed)) | ||
@test PSY.get_units_base(get_system(results_ed)) == "DEVICE_BASE" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also test that the errors work as expected when we can't find the system file and when we set populate_units
without setting populate_system
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once this test is implemented we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GabrielKS, could you confirm or deny the implementation of the test?
Tests passing