Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/thermal modeling changes #1059

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Jd/thermal modeling changes #1059

merged 6 commits into from
Feb 19, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Feb 19, 2024

This PR fixes some loops in ThermalMultiStart and also uses nothing for LB on variables for UC. The rationale for this is that in some cases thermal units with negative limits are being used to represent transactions with other areas where the power is negative. This is a work around while we implement a more rigorous way to do inter-regional transactions.

@jd-lara jd-lara requested a review from sourabhdalvi February 19, 2024 15:43
@jd-lara jd-lara self-assigned this Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Performance Results

Version Precompile Time
Main 3.285255294
This Branch 3.22066535
Version Build Time
Main-Build Time Precompile 50.807528699
Main-Build Time Postcompile 2.599317277
This Branch-Build Time Precompile 51.207137836
This Branch-Build Time Postcompile 2.753019327

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (1c05b65) 80.51% compared to head (901573e) 80.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   80.51%   80.52%           
=======================================
  Files         115      115           
  Lines       12395    12396    +1     
=======================================
+ Hits         9980     9982    +2     
+ Misses       2415     2414    -1     
Flag Coverage Δ
unittests 80.52% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/devices_models/devices/AC_branches.jl 76.95% <100.00%> (-0.11%) ⬇️
src/devices_models/devices/thermal_generation.jl 90.15% <61.90%> (-0.29%) ⬇️

... and 1 file with indirect coverage changes

@jd-lara jd-lara merged commit c258189 into main Feb 19, 2024
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/thermal_modeling_changes branch February 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants