Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiStart with nothing #1036

Merged
merged 6 commits into from
Jan 8, 2024
Merged

MultiStart with nothing #1036

merged 6 commits into from
Jan 8, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 5, 2024

closes #1035

@jd-lara jd-lara self-assigned this Jan 5, 2024
@jd-lara jd-lara requested a review from jarry7 January 5, 2024 05:53
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Performance Results

Version Precompile Time
Main 3.346710936
This Branch 3.388883567
Version Build Time
Main-Build Time Precompile 53.883236466
Main-Build Time Postcompile 2.847643763
This Branch-Build Time Precompile 54.791224771
This Branch-Build Time Postcompile 2.814312322

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (492aee9) 80.42% compared to head (cfef00b) 80.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   80.42%   80.41%   -0.01%     
==========================================
  Files         116      116              
  Lines       12423    12428       +5     
==========================================
+ Hits         9991     9994       +3     
- Misses       2432     2434       +2     
Flag Coverage Δ
unittests 80.41% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/devices_models/devices/thermal_generation.jl 90.43% <66.66%> (-0.30%) ⬇️

@jd-lara jd-lara requested a review from rodrigomha January 5, 2024 20:25
Copy link
Contributor

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jd-lara jd-lara merged commit a8be7cf into main Jan 8, 2024
8 of 9 checks passed
@jd-lara jd-lara deleted the jd/ntp_debug branch January 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage better Nothing returns in ThermalMultiStart
2 participants