Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump power models #1034

Merged
merged 5 commits into from
Jan 11, 2024
Merged

bump power models #1034

merged 5 commits into from
Jan 11, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 3, 2024

No description provided.

@jd-lara jd-lara marked this pull request as ready for review January 3, 2024 04:42
@jd-lara jd-lara self-assigned this Jan 3, 2024
@jd-lara jd-lara requested a review from daniel-thom January 3, 2024 04:42
@jd-lara
Copy link
Member Author

jd-lara commented Jan 3, 2024

The tests are failing due to the change in the constraint creation in PowerModels.jl lanl-ansi/PowerModels.jl#819

@@ -13,7 +13,7 @@ end
# replicates PM.build_mn_opf
function instantiate_nip_expr(pm::PM.AbstractPowerModel)
for n in eachindex(PM.nws(pm))
@assert !PM.ismulticonductor(pm; nw = n)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@@ -104,7 +103,7 @@
# replicates PM.build_mn_opf_bf_strg
function instantiate_bfp_expr(pm::PM.AbstractPowerModel)
for n in eachindex(PM.nws(pm))
@assert !PM.ismulticonductor(pm; nw = n)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change

@jd-lara jd-lara merged commit 2c4d558 into main Jan 11, 2024
0 of 6 checks passed
@jd-lara jd-lara deleted the jd/bump_power_models branch January 11, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants