Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cat with preallocated array to fix stackoverflow issue #1027

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

rodrigomha
Copy link
Contributor

@rodrigomha rodrigomha commented Dec 13, 2023

Check this discussion for the issue of cat: JuliaLang/julia#30796

Copy link
Contributor

Performance Results

Version Precompile Time
Main 7.375954714
This Branch 7.511784739
Version Build Time
Main-Build Time Precompile 68.057626996
Main-Build Time Postcompile 3.03344811
This Branch-Build Time Precompile 72.67073614
This Branch-Build Time Postcompile 3.136726246

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #1027 (b11bfd9) into main (3f6e556) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   79.85%   79.82%   -0.03%     
==========================================
  Files         116      116              
  Lines       12457    12414      -43     
==========================================
- Hits         9948     9910      -38     
+ Misses       2509     2504       -5     
Flag Coverage Δ
unittests 79.82% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/simulation/optimization_output_cache.jl 93.84% <71.42%> (-6.16%) ⬇️

... and 18 files with indirect coverage changes

@jd-lara jd-lara self-assigned this Dec 13, 2023
@jd-lara jd-lara merged commit 6e1e15e into main Dec 13, 2023
9 checks passed
@jd-lara jd-lara deleted the rhjddt/fix_cache_long_concat branch December 15, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants