Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to StaticBranch in FixValueFeedForward #1019

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

alefcastelli
Copy link
Contributor

No description provided.

@alefcastelli alefcastelli marked this pull request as draft November 7, 2023 23:24
@rodrigomha rodrigomha changed the title afc/changes to consider ac branche in FixValueFeedForward Changes to StaticBranch in FixValueFeedForward Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1019 (6dfcc11) into main (29ff39f) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   80.41%   80.38%   -0.04%     
==========================================
  Files         116      116              
  Lines       12312    12261      -51     
==========================================
- Hits         9901     9856      -45     
+ Misses       2411     2405       -6     
Flag Coverage Δ
unittests 80.38% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s_models/device_constructors/branch_constructor.jl 80.00% <100.00%> (-0.11%) ⬇️
src/devices_models/devices/AC_branches.jl 73.77% <0.00%> (-0.41%) ⬇️

... and 16 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Performance Results

Version Precompile Time
Main 6.626842767
This Branch 6.659961697
Version Build Time
Main-Build Time Precompile 62.62849188
Main-Build Time Postcompile 2.976755155
This Branch-Build Time Precompile 64.827780879
This Branch-Build Time Postcompile 2.97516979

@jd-lara jd-lara marked this pull request as ready for review November 16, 2023 14:26
@jd-lara jd-lara merged commit 712532b into main Nov 16, 2023
1 of 5 checks passed
@jd-lara jd-lara deleted the afc/FixValueFeedForward-for-branches branch November 20, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants