Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of results with unknown timestamps #1008

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

daniel-thom
Copy link
Contributor

No description provided.

@daniel-thom daniel-thom marked this pull request as draft September 14, 2023 21:46
src/core/results_by_time.jl Outdated Show resolved Hide resolved
src/simulation/decision_model_simulation_results.jl Outdated Show resolved Hide resolved
src/simulation/decision_model_simulation_results.jl Outdated Show resolved Hide resolved
@daniel-thom daniel-thom force-pushed the fix-invalid-timestamp-handling branch from 19834ff to ec73184 Compare September 14, 2023 21:57
@github-actions
Copy link
Contributor

Performance Results

Version Precompile Time
Main 8.666655971
This Branch 8.703524457
Version Build Time
Main-Build Time Precompile 77.01813601
Main-Build Time Postcompile 4.794826714
This Branch-Build Time Precompile 78.442498249
This Branch-Build Time Postcompile 4.880074556

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1008 (ec73184) into main (e69e29d) will decrease coverage by 0.03%.
The diff coverage is 76.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1008      +/-   ##
==========================================
- Coverage   80.26%   80.23%   -0.03%     
==========================================
  Files         116      116              
  Lines       12313    12276      -37     
==========================================
- Hits         9883     9850      -33     
+ Misses       2430     2426       -4     
Flag Coverage Δ
unittests 80.23% <76.92%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/simulation/decision_model_simulation_results.jl 97.00% <66.66%> (-1.77%) ⬇️
src/core/results_by_time.jl 47.72% <100.00%> (+2.48%) ⬆️

... and 15 files with indirect coverage changes

@daniel-thom daniel-thom requested a review from jd-lara September 14, 2023 23:43
@jd-lara jd-lara marked this pull request as ready for review September 15, 2023 21:18
@jd-lara jd-lara merged commit 0dfaf53 into main Sep 15, 2023
7 of 8 checks passed
@jd-lara jd-lara deleted the fix-invalid-timestamp-handling branch September 15, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants