Skip to content

Commit

Permalink
address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jd-lara committed Jun 24, 2024
1 parent 57db2b5 commit 28c80ac
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/core/optimization_container.jl
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ function _make_system_expressions!(
if length(subnetworks) > 1
throw(
IS.ConflictingInputsError(
"AreaBalancePowerModel doesn't support systems with multiple asynchrous areas",
"AreaBalancePowerModel doesn't support systems with multiple asynchronous areas",
),
)
end
Expand Down
8 changes: 1 addition & 7 deletions src/devices_models/devices/AC_branches.jl
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ const ValidPTDFS = Union{
Tuple{Dict{Int64, Int64}, Dict{String, Int64}},
Matrix{Float64},
},
VirtualPTDF{
PNM.VirtualPTDF{
Tuple{Vector{String}, Vector{Int64}},
Tuple{Dict{String, Int64}, Dict{Int64, Int64}},
},
Expand Down Expand Up @@ -484,7 +484,6 @@ function _make_flow_expressions!(
time_steps,
)

t1_ = time()
jump_model = get_jump_model(container)

tasks = map(branches) do name
Expand Down Expand Up @@ -515,8 +514,6 @@ function _make_flow_expressions!(
end
=#

t2_ = time()
#@error "time to build PTDF expressions $branch_Type $(t2_ - t1_)"
return branch_flow_expr
end
"""
Expand Down Expand Up @@ -554,7 +551,6 @@ function add_constraints!(
B,
)
jump_model = get_jump_model(container)
t1 = time()
for name in branches
for t in time_steps
branch_flow[name, t] = JuMP.@constraint(
Expand All @@ -563,8 +559,6 @@ function add_constraints!(
)
end
end
t2 = time()
#@error "time to build PTDF constraints $B $(t2 - t1)"
return
end

Expand Down
2 changes: 1 addition & 1 deletion src/network_models/area_balance_model.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
function add_constraints(
function add_constraints!(
container::OptimizationContainer,
::Type{CopperPlateBalanceConstraint},
sys::PSY.System,
Expand Down

0 comments on commit 28c80ac

Please sign in to comment.