Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve IS prefix in submodules (fixes #398) #399

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Resolve IS prefix in submodules (fixes #398) #399

merged 1 commit into from
Sep 24, 2024

Conversation

GabrielKS
Copy link
Contributor

Pretty straightforward: I removed the IS prefix in submodules where it was not necessary and added IS aliases in each submodule for the cases where it is necessary. Right now there are no references to IS in IS.Simulation but I think it's probably a good practice to have the alias for the future anyway. Fixes #398.

@GabrielKS GabrielKS self-assigned this Sep 24, 2024
@GabrielKS GabrielKS added the bug Something isn't working label Sep 24, 2024
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks I left some of this code behind.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.28%. Comparing base (02e3688) to head (a353a06).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Optimization/optimization_problem_results.jl 0.00% 1 Missing ⚠️
src/Optimization/optimization_test_utils.jl 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          71       71           
  Lines        5484     5484           
=======================================
  Hits         4293     4293           
  Misses       1191     1191           
Flag Coverage Δ
unittests 78.28% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Optimization/Optimization.jl 100.00% <ø> (ø)
src/Simulation/Simulation.jl 100.00% <ø> (ø)
src/Optimization/optimization_problem_results.jl 0.00% <0.00%> (ø)
src/Optimization/optimization_test_utils.jl 14.28% <0.00%> (ø)

@GabrielKS GabrielKS merged commit a763ee0 into main Sep 24, 2024
9 of 10 checks passed
@GabrielKS GabrielKS deleted the gks/fix_398 branch September 24, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IS is not defined within submodules
2 participants